Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1412, 1413, 1414] Fixes CSV upload modal bugs #262

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

vsreekanti
Copy link
Contributor

Describe your changes and why you are making these changes

The CSV upload modal had a few bugs that made it confusing to use. This PR fixes the following:

  • ENG-1412: The modal was way too narrow, so you couldn't see any of the data you uploaded.
  • ENG-1413: The modal didn't close after upload, so it seemed like nothing actually uploaded.
  • ENG-1414: The preview showed an ID column that wasn't included in the original data.

image

There's still a tiny bug where I'd like to have the dialog expand to show the full 5 rows, but I couldn't fix that quickly.

Related issue number (if any)

See above

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A] If this is a new feature, I have added unit tests and integration tests.
  • [N/A] I have run the integration tests locally and they are passing.
  • [N/A] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@vsreekanti vsreekanti added the skip_integration_test Skips required integration test (only documentation/UI changes) label Jul 27, 2022
@vsreekanti vsreekanti force-pushed the eng-1412-eng-1413-eng-1414 branch from 8af1f81 to 5bc4db0 Compare July 27, 2022 22:41
Copy link
Contributor

@agiron123 agiron123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vsreekanti vsreekanti merged commit 28faf76 into main Jul 28, 2022
@vsreekanti vsreekanti deleted the eng-1412-eng-1413-eng-1414 branch July 28, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants